Skip to content

[PF-] Fix syncing gh-pages#4908

Merged
vedrani merged 3 commits intomasterfrom
pf-fix-picasso-docs-gh-pages
Mar 9, 2026
Merged

[PF-] Fix syncing gh-pages#4908
vedrani merged 3 commits intomasterfrom
pf-fix-picasso-docs-gh-pages

Conversation

@vedrani
Copy link
Copy Markdown
Collaborator

@vedrani vedrani commented Mar 9, 2026 •
edited by github-actions Bot
Loading

[FX-NNNN]

Description

Describe the changes and motivations for the pull request.

How to test

  • Temploy
  • FIXME: Add the steps describing how to verify your changes

Screenshots

Before. After.
Insert screenshots or screen recordings Insert screenshots or screen recordings

Development checks

  • Add changeset according to guidelines (if needed)
  • Double check if picasso-tailwind-merge requires major update (check its README.md)
  • Read CONTRIBUTING.md and Component API principles
  • Make sure that additions and changes on the design follow Toptal's BASE design, and it's been already discussed with designers at #-base-core
  • Annotate all props in component with documentation
  • Create examples for component
  • Ensure that deployed demo has expected results and good examples
  • Ensure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.
  • Self reviewed
  • Covered with tests (visual tests included)

Breaking change

  • codemod is created and showcased in the changeset
  • test alpha package of Picasso in StaffPortal

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

Alpha packages

Manually trigger the publish.yml workflow to publish alpha packages. Specify pull request number as a parameter (only digits, e.g. 123).

PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@vedrani vedrani self-assigned this Mar 9, 2026
@vedrani vedrani requested a review from a team as a code owner March 9, 2026 11:24
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 9, 2026 •
edited
Loading

⚠️ No Changeset found

Latest commit: e825b7d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

denieler
denieler reviewed Mar 9, 2026
View reviewed changes
Comment thread .github/actions/deploy-to-gh-pages/action.yml Outdated
if git push origin gh-pages; then
echo "gh-pages branch synced with deployment"
else
echo "::warning::Failed to sync gh-pages branch (concurrent deployment?). Next deployment will self-heal."
Copy link
Copy Markdown
Collaborator

@denieler denieler Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this does not look like a solid solution 🤔

denieler
denieler approved these changes Mar 9, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@denieler denieler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix the problem and figure out other problems later 👍 thanks for fixing it 🙇‍♂️

github-actions Bot added a commit that referenced this pull request Mar 9, 2026
@github-actions
Sync: PR #4908 Preview
7eb9c54
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 9, 2026

📖 Storybook Preview

🚀 Your Storybook preview is ready: View Storybook

📍 Preview URL: https://toptal.github.io/picasso/prs/4908/

This preview is updated automatically when you push changes to this PR.

@vedrani vedrani merged commit 424c0f1 into master Mar 9, 2026
14 checks passed
@vedrani vedrani deleted the pf-fix-picasso-docs-gh-pages branch March 9, 2026 13:13
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 9, 2026

🗑️ Storybook preview cleaned up

The preview deployment has been automatically removed since this PR was closed.

github-actions Bot added a commit that referenced this pull request Mar 9, 2026
@github-actions
Sync: Cleanup PR #4908
8791bfe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@denieler denieler denieler approved these changes

Assignees

@vedrani vedrani

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vedrani @denieler